Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend LED mode: Mixed ON mode #604

Closed
hyteoo opened this issue Feb 25, 2018 · 6 comments
Closed

Extend LED mode: Mixed ON mode #604

hyteoo opened this issue Feb 25, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request leds relay
Milestone

Comments

@hyteoo
Copy link
Contributor

hyteoo commented Feb 25, 2018

I'm currently working on several device types including single relay switches inside various devices.
An example would be ESP-01 based relays found on ebay (ex. http://ebay.to/2opYkTC)
For simplicity's sake and also limited pins to deal with, I usually prefer having 1 indicator LED instead of 2 like sonoffs. I usually use a switch with build in LED.

I also want wifi status to be indicated by the LED.
For this, a new mode would be welcomed based on Mixed but reversed.... LED on when relay is on and viceversa.
Also when turning on/off, LED should instantly respond (currently in mixed mode, the LED toggles a few seconds after the relay is toggled)

Here's an example:
20180225_165707

@xoseperez
Copy link
Owner

Hi
I have added a new mode to your requirements and renamed some others trying to make them more understandable. "Relay & WiFi" mode will stay ON if any relay is ON and OFF otherwise and the WiFi status will blink on top of that. The "Find me & WiFi" will do the opposite.

@xoseperez xoseperez self-assigned this Feb 26, 2018
@xoseperez xoseperez added this to the 1.12.4 milestone Feb 26, 2018
@hyteoo
Copy link
Contributor Author

hyteoo commented Feb 26, 2018

That is great (and fast :). Naming looks more straightforward now.
Can't wait to test that.

@xoseperez
Copy link
Owner

You can already do it using the dev branch to build and flash your device.

@xoseperez
Copy link
Owner

This is staged for release.

@hyteoo
Copy link
Contributor Author

hyteoo commented Feb 28, 2018

Tested this, works correctly
However there is a 3 second delay between the time the relay switches and the LED is toggled.
It doesn't respond like for example "Relay Status". Can you specify where is this delay defined?

@xoseperez
Copy link
Owner

This is due to the way the WiFi notification works. It's something to change in the future. Basically, it will "recalculate" the blink mode after the current blink cycle which is 5 seconds...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request leds relay
Projects
None yet
Development

No branches or pull requests

2 participants