Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DST by region #664

Closed
WayneManion opened this issue Mar 12, 2018 · 3 comments
Closed

DST by region #664

WayneManion opened this issue Mar 12, 2018 · 3 comments
Labels
enhancement New feature or request ntp
Milestone

Comments

@WayneManion
Copy link

This is a pretty first-world kind of problem, but Espurna seems to follow European rules for Daylight Savings Time. All my devices think it's 7:17 right now, but in America it is 8:17 because the US does its Spring clock adjustment the second Sunday in March and Europe does it on the last Sunday in March.

The US Fall adjustment happens the first Sunday in November vs. the last Sunday in October in Europe.

Is there a simple way to implement regional DST-following in Espurna? Perhaps default to Euro rules and have a checkbox to use the US dates?

@sashimanu-san
Copy link

Then the rest of the world will complain too, hihi

There's tzdata database for that.

@xoseperez
Copy link
Owner

True, but let's walk step by step. I have done a PR against the NTP library ESPurna uses to include DST calculation for different zones and implemented USA calculations.

gmag11/NtpClient#58

@xoseperez xoseperez added enhancement New feature or request ntp labels Mar 13, 2018
@xoseperez xoseperez modified the milestones: 1.13.0, 1.12.5 Mar 13, 2018
@xoseperez
Copy link
Owner

Staged for release. At the moment it requires NTPClientLib develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ntp
Projects
None yet
Development

No branches or pull requests

3 participants