Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscores should be disallowed or at least warned in hostname #874

Closed
iMartyn opened this issue May 20, 2018 · 1 comment
Closed

Underscores should be disallowed or at least warned in hostname #874

iMartyn opened this issue May 20, 2018 · 1 comment

Comments

@iMartyn
Copy link

iMartyn commented May 20, 2018

Underscores have a reserved meaning in DNS, they also cause certain devices (notably some android phones) to not see the AP.

This creates problems downstream, so we should warn users at the very least that the hostname is likely to cause problems.

@xoseperez xoseperez added this to the 1.12.7 milestone May 21, 2018
xoseperez added a commit that referenced this issue May 21, 2018
@xoseperez
Copy link
Owner

I have added checks to the hostname following these rules:
"RFCs mandate that a hostname's labels may contain only the ASCII letters 'a' through 'z' (case-insensitive), the digits '0' through '9', and the hyphen. Hostname labels cannot begin or end with a hyphen. No other symbols, punctuation characters, or blank spaces are permitted."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants