Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for Generic ESP01 boards with 512KiB flash #2185

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

ziggurat29
Copy link
Contributor

added board def and have tested with boards on-hand. These are the first generation ESP01 boards with an 8 pin header and only 512 KiB flash.

Copy link
Collaborator

@mcspr mcspr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. We still have 512kb flags and it still (somehow) works :) Even while Espressif sdk did remove any mention of it from the most recent versions. Not a concern yet though for Arduino base.

@mcspr
Copy link
Collaborator

mcspr commented Mar 19, 2020

I was also curious about Update removal from the build, since there is no point in OTA in such conditions.
basic builds:
493120 - defaults
484928 - OTA_ARDUINOOTA_SUPPORT=0, OTA_CLIENT=OTA_CLIENT_NONE
481856 - #if0 onUpdate callbacks in web.ino + the above

@ziggurat29
Copy link
Contributor Author

ziggurat29 commented Mar 19, 2020

I was also curious about Update removal from the build, since there is no point in OTA in such conditions.

that makes sense to me. feel free to change if you like, or perhaps I can try it out here since I have these boards on hand and update the PR; let me know if you want me to do that.
at the moment, I am working on gosund wp3 definition in a separate branch which will be a separate submission.

@mcspr mcspr merged commit 7496606 into xoseperez:dev Mar 20, 2020
mcspr added a commit that referenced this pull request Mar 20, 2020
@mcspr
Copy link
Collaborator

mcspr commented Mar 20, 2020

I have added the web part as OTA_WEB_SUPPORT, which should also cut the WebUI 'Upgrade' input from the Admin panel. esp01 hardware updated with the defines

@ziggurat29 ziggurat29 deleted the board-esp01-512k branch March 20, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants