Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Improve Scheduler type interface #2612

Closed
wants to merge 1 commit into from

Conversation

opticron
Copy link

@opticron opticron commented Jul 9, 2024

The scheduler type selection is not intuitive as there is no prompt to change the empty drop-down box to another value. This makes it obvious that something needs to be selected.

mcspr added a commit that referenced this pull request Jul 13, 2024
revert set:/del: merge, do not allow to miss key pruning

allow certain fields to have 'unset' state via 'required' attribute
ensure 'unset' fields cannot be added to data payload

generate ui tooltip when 'unset' field is created in a group or erased by user

ref. #2612
@mcspr
Copy link
Collaborator

mcspr commented Jul 13, 2024

What about reportValidity() instead?
https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/reportValidity

Non-interactive part
https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/checkValidity

having more text in an already pretty narrow input might be too much?
ed26dbd attempts to force everything through validity checks before being allowed to apply any settings, I'd expect this would be much more apparent than select label. for schedule inputs, this generates a warning immediately after template is injected. plus, there is also an annoying warning after editing the field for basic text inputs

The scheduler type selection is not intuitive as there is no prompt to
change the empty drop-down box to another value. This makes it obvious
that something needs to be selected.
@opticron
Copy link
Author

Thanks for adding that. Does that commit obsolete this change, then?

@mcspr
Copy link
Collaborator

mcspr commented Jul 16, 2024

"makes it obvious" that elem is required when editing should be solved, yes

@opticron
Copy link
Author

Ack

@opticron opticron closed this Jul 16, 2024
@opticron opticron deleted the improve-sched-type-web branch July 16, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants