Is it possible to embed images?

[pdamoc]

I have a workflow where I'm generating the .xlsx and uploading it to S3.

Would it be possible to embed an image either by reading a file or by using a Base64 encoding?

If the current version does not support this would it be technically feasible to add such a feature?

[Fabi755]

This also is not possible but it's a nice new feature. I validate how to include this function.

[proactively]

I made a start on this in my fork https://github.com/proactively/elixlsx on branch "image-support"

A few apologies: My editor setup runs mix format automatically so by the time I was half way through I realised half the files were reformatted. So I backtracked, ran mix format on the whole codebase then re-applied my wip. So my image support will only apply cleanly to a mix formatted repo.

Also not much in the way of tests and I don't have any time right now to add them.

Anyway, just a heads up in case it's useful for anyone

[xou]

Awesome! Feel free to send a pull request for the mix formatted codebase at any time as well.

[manveru]

@proactively are you still planning to make a PR for this?

[proactively]

Urgh. yes. 12 hours a day just hasn't been enough work time. I'll see what it will take to rebase it all on your new changes

…

On 25 Feb 2019, at 12:30, Michael Fellinger ***@***.***> wrote: @proactively <https://github.com/proactively> are you still planning to make a PR for this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjJN90Tic1yTVv7Yikl9NMn14fkNoXRbks5vQ8lRgaJpZM4PIbA6>.

[proactively]

PR submitted

[elalaouifaris]

Hi,
Really cool feature. Do you still have plans to merge this in the base code?
Currently checking this for a side project where I need image upload in excel files.

Thanks!

[proactively]

Hi, I saw your mail just today and was prompted to re-merge the Image support. Only to find that you have done it already. So thank you!! Hope you find it useful. Cheers, Sean

…

On Sat, May 9, 2020 at 2:37 PM Moulay Driss EL ALAOUI FARIS < ***@***.***> wrote: Hi, Really cool feature. Do you still have plans to merge this in the base code? Currently checking this for a side project where I need image upload in excel files. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#46 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIZE355O5VXIKJN6RYIFPZDRQVFBFANCNFSM4DZBWA5A> .