Make write_to and write_to_memory adhere to their typespecs #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typespecs state that {:ok, String.t()} is returned, but
:zip.create will return {:ok, [char()]}.
|
Thank you very much for this PR. Would it make sense to fix the typespec instead, so that users of the API are not broken by the next release? |
|
@xou good point. I'll try to change the typespec instead and make a new PR |
xou
force-pushed
the
master
branch
3 times, most recently
from
e7bdfd0
to
68acd8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typespecs state that {:ok, String.t()} is returned on success, but :zip.create will return {:ok, [char()]}.