Image support - continuation #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for embedding images in workbooks. It technically does two main things: - Implements the changes introduced by [proactively's image support branch](https://github.com/proactively/elixlsx/tree/image-support-no-reformat) on top of the most recent commit to master - Adds `width` and `height` options to `Elixlsx.Image` so that it's possible to configure how many columns/rows and image should occupy
Closed
|
Hi guys, any possibility it is going to be released anytime soon? 🤔 I'm depending on this branch in my project and I would love it to be released. Or is there anything it is missing now? |
|
Hi @xou, thank you for your great work in this library, much appreciated. Anyways, is there any possibility that we can merge this PR? i have a case where i need to add images. Thank you! |
Closed
krishandley
added a commit
to krishandley/elixlsx
that referenced
this pull request
Aug 25, 2023
The previous work in xou#124 by x and x was using a twoCellAnchor but that's quite tricky to get right. This is now using a oneCellAnchor to make the calculations much simpler. I have added a few extra tests. I also fixed the formula because I couldn't run the example file without doing that first.
krishandley
added a commit
to krishandley/elixlsx
that referenced
this pull request
Aug 25, 2023
The previous work in xou#124 by @ngscheurich and @joseustra was using a twoCellAnchor but that's quite tricky to get right. This is now using a oneCellAnchor to make the calculations much simpler. The api is almost the same, but you don't need to add any emu based values for offsets. You can also align the image from the right of a cell. That's something I needed but you also have to take the max character width into account. Also added a few extra tests. I also fixed the formula because I couldn't run the example file without doing that first.
krishandley
added a commit
to krishandley/elixlsx
that referenced
this pull request
Aug 26, 2023
The previous work in xou#124 by @ngscheurich and @joseustra was using a twoCellAnchor but that's quite tricky to get right. This is now using a oneCellAnchor to make the calculations much simpler. The api is almost the same, but you don't need to add any emu based values for offsets. You can also align the image from the right of a cell. That's something I needed but you also have to take the max character width into account. Also added a few extra tests for a few basic files. I also fixed the formula because it didn't work in the example file.
xou
force-pushed
the
master
branch
3 times, most recently
from
e7bdfd0
to
68acd8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of the work done by @ngscheurich on the PR #97
As the development of the original PR looks stopped, and we need this feature on my company's project, I decided to try to address the comments so we can try to merge it.
Please, let me know if you have any concerns about this PR.
Note: the whole work was done by @ngscheurich, I'm just trying to address the comments.
From original PR:
This adds support for embedding images in workbooks. It technically does
two main things:
Implements the changes introduced by proactively's image support
branch
on top of the most recent commit to master
Adds
widthandheightoptions toElixlsx.Imageso that it'spossible to configure how many columns/rows and image should occupyThis adds support for embedding images in workbooks. It technically does
two main things:
Implements the changes introduced by proactively's image support
branch
on top of the most recent commit to master
Adds
widthandheightoptions toElixlsx.Imageso that it'spossible to configure how many columns/rows and image should occupy