Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change border style to resolve Excel for Mac issue #18

Merged
merged 1 commit into from
Jan 28, 2017

Conversation

brucepom
Copy link
Contributor

After some experimentation I found that this change resolved the problem I encountered opening files generate by elixlsx in Excel for Mac. See this issue for more detail: #17.

I was concerned that this change might break other Excel editors. I couldn't find a schema definition that seemed relevant so I created a simple spreadsheet in Google Sheets. I exported the Google Sheet as xlsx, extracted the content and took a look at styles.xml. This is the relevant part I found:

<borders count="1">
  <border>
    <left/>
    <right/>
    <top/>
    <bottom/>
  </border>
</borders>

Seeing that Google Sheets exports xlsx files with the borders ordered left, right, top, bottom as proposed in my PR gave me confidence that this ordering is likely the most compatible if it's what Google Sheet generates.

@brandonparsons
Copy link
Contributor

👍

@xou xou merged commit 2ec48e7 into xou:master Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants