Change border style to resolve Excel for Mac issue #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some experimentation I found that this change resolved the problem I encountered opening files generate by elixlsx in Excel for Mac. See this issue for more detail: #17.
I was concerned that this change might break other Excel editors. I couldn't find a schema definition that seemed relevant so I created a simple spreadsheet in Google Sheets. I exported the Google Sheet as xlsx, extracted the content and took a look at styles.xml. This is the relevant part I found:
Seeing that Google Sheets exports xlsx files with the borders ordered left, right, top, bottom as proposed in my PR gave me confidence that this ordering is likely the most compatible if it's what Google Sheet generates.