Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI for GSettings #142

Closed
xou816 opened this issue Mar 14, 2021 · 8 comments
Closed

Add GUI for GSettings #142

xou816 opened this issue Mar 14, 2021 · 8 comments

Comments

@xou816
Copy link
Owner

xou816 commented Mar 14, 2021

No description provided.

@tmpr
Copy link

tmpr commented Apr 9, 2021

I might right away look into this. I will try to add a "Theme: {Light, Dark, System} " in the options.

@xou816
Copy link
Owner Author

xou816 commented Apr 9, 2021

Thanks! :) if you need any pointers on where to put stuff or whatever, feel free to ask!

@sei0o
Copy link
Contributor

sei0o commented Dec 17, 2021

I'm thinking of working on this issue. Shortwave (internet radio app) uses AdwPreferencesWindow and I suppose we can make use of this.

@xou816
Copy link
Owner Author

xou816 commented Dec 18, 2021

Definitely the way to go :) thanks sei0o !!

@sei0o sei0o mentioned this issue Feb 9, 2022
@sei0o
Copy link
Contributor

sei0o commented Mar 9, 2022

This could be closed now? :)

@xou816
Copy link
Owner Author

xou816 commented Mar 11, 2022

Oh indeed :) thanks for the heads up!!

@xou816 xou816 closed this as completed Mar 11, 2022
@pesader
Copy link

pesader commented Apr 14, 2022

Would it be possible to add a "Follow system theme" option to the settings? It could change the gsettings prefers-dark-theme to false, as you mentioned here.

I got that Spot stays dark intentionally, but I'd love to have light/dark consistency especially now that Dark Mode is officially a thing on GNOME 42 :)

And thanks a lot for developing Spot! It is amazing to have a good looking open source client for my favorite music streaming service 🎵❤️

@xou816
Copy link
Owner Author

xou816 commented Apr 28, 2022

Hi! Yes, this sounds reasonable. Could you open a dedicated issue for this? Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants