Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot uses wrong Flatpak-GTK Theme #187

Closed
tmpr opened this issue Apr 9, 2021 · 2 comments
Closed

Spot uses wrong Flatpak-GTK Theme #187

tmpr opened this issue Apr 9, 2021 · 2 comments
Labels
bug Something isn't working question Further information is requested

Comments

@tmpr
Copy link

tmpr commented Apr 9, 2021

I downloaded Spot from the Pop!-Shop as a Flatpak-App, and when opening it uses the Pop-Dark theme (which is already better than Adawaita), even though I have the Pop-Light theme enabled. Other Flatpak-Apps use the proper light theme.

To Reproduce
Download from Pop-Shop on Pop-OS via Flatpak, with Pop-Light enabled in Tweaks as the application-theme.
(Maybe install Night Theme Switcher GNOME-Extensions, however this doesn't affect other Flatpak apps it seems.)

Expected behavior
I would expect a light theme, and for it to switch whenever themes change.

General information:

  • Distribution: Pop!_OS 20.10
  • Installation method [e. g. built from source, installed from Flathub...]: Pop-Shop / Flatpak
  • Version [e.g. 0.1.0]: 0.1.2
  • Device used [e. g. desktop, phone...]: Desktop

Stack trace:
If applicable, run the application from a terminal and paste relevant log output.

flatpak run --env=RUST_BACKTRACE=full dev.alextren.Spot

Gtk-Message: 10:28:38.847: Failed to load module "appmenu-gtk-module"
Gtk-Message: 10:28:38.900: Failed to load module "canberra-gtk-module"
Gtk-Message: 10:28:38.901: Failed to load module "canberra-gtk-module"

** (process:22194): WARNING **: 10:28:39.004: Error writing credentials to socket: Error sending message: Broken pipe

Additional context
I do use the extension "Night Theme Switcher", and it would be optimal if triggering the Switch, Spot would react properly.

@tmpr tmpr added the bug Something isn't working label Apr 9, 2021
@xou816
Copy link
Owner

xou816 commented Apr 9, 2021

Hi!

This is because Spot uses the dark theme variant by default but this can be changed. I wonder if this should be the default (felt right for a media player but that's up for discussion).

For the flatpak version, until #142 is implemented, you'll have to fiddle with the gsettings manually, by editing ~/.var/app/dev.alextren.Spot/config/glib-2.0/settings/keyfile and adding this line: prefers-dark-theme=false.

Hope this helps!

@tmpr
Copy link
Author

tmpr commented Apr 9, 2021

Nice! This works great, thank you!

I personally like light themes, as I often work in the morning next to a window and the sun-glare makes dark themes hard to read, but as most people prefer dark themes I think your decision is probably not bad! :)

PS: Really cool spotify client, thank you for providing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants