-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window to big for PinePhone #50
Comments
Thank you for your report :) |
The window is also too big in Plasma Mobile, so I don't think it's a Phosh issue. |
K, thanks! I'll investigate and try to go below 720/2 width :) |
The necessary library for this is libhandy which also features a rust binding. |
libhandy is being used, but I wrongly assumed I could expect a window of at least 720pixels (did not account for the scaling), but really I shouldn't assume any size at all. I'll upload a test build later today which should behave better on smaller screens! |
Sorry, didn't looked into your code yet. If you have any question regarding libhandy i could help a bit. |
On my pinephone i have the same issue, but just happened something strange after using the search, the music controls are outside of the screen (the window is too big in the vertical) |
Thank you all for your reports! I should setup a vm one of these days to test this on phones but in the meantime... Here is a build you can try: https://github.com/xou816/spot/suites/2062132539/artifacts/41632717 It should be able to fit more easily on small screens. |
Thanks for your build. Quick feedback: Search result string should be wrapped otherwise the window size will increase. |
And of course the search results as well. |
Oh good catch! Thanks :) |
Can't test on mobile (flatpak is X86_64 only/depends on the X86_64 GNOME runtime) but the max width no longer seems locked. One more thing I've noticed: There is currently no way to directly see the name of the current song (see screenshot below) when using it on smaller devices; maybe something like what iOS Spotify is doing (adding a seperate view with the current song and not providing controls directly) could be done here as well? |
Ah, sorry, did not think of other archs... thank you for your feedback however! Would you mind opening a dedicated issue for this? It will take some work to have something that works great on mobile; I will limit this issue to making it usable if a bit awkward :) For instance the seeking bar does not make much sense... |
Just hopping in to say this is the one barrier that's keeping me from switching from the official spotify android app via Anbox to Spot. Happy to hear this being discussed. Go team! |
Err, don't know if it will be useful, but if anyone has a phone that uses x86 for some reason, here is a more recent build that adds wrapping as per @janbrummer's suggestion :) https://github.com/xou816/spot/suites/2062387210/artifacts/41640297 |
That's better, albums and artists still seems to have a fixed number of entries per row, so that only 1 album is visible. |
A little bit more feedback regarding window size: Phosh uses a scaling factor 2 which means that your application needs to fit for 360x720. At the moment height is only a problem as soon as search is used (it's 810px min then). Height issue in search mode is caused by adding your Albums and Artists expander into a simple box. You would need to add a scrolledwindow as parent and it should be fine. Side note (and it should be really a new ticket): song_title label should use xalign 0, otherwise titles are jumping during resize. |
Thank you for the detailed explanation! I'll look into that! |
I am closing this for now, thank you all for the help. Overall, a lot of small changes should have made things better on mobile displays in 0.1.8. Feel free to open specific issues if you encounter something! |
As you can see on the Picture the window is to large if you use the PinePhone in vertical rotation (or normal use). In horizontal rotation it works fine. The PinePhone uses as screen resolution 720 x 1440 px with double scale PhoshUI.
The text was updated successfully, but these errors were encountered: