Resolve #539 #599
Merged
Resolve #539 #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug that caused backwards skips to be accumulated Placate rustfmt Fixed another edge case when at the start of a playlist
xou816
reviewed
Feb 19, 2023
There was a problem hiding this comment.
pretty clean and straightforward! thanks for the contribution!!
as for PositionMicros: I would just merge both eventually. but if you want to keep two versions that's fine -- in that case maybe modifying it to work with milliseconds is interesting; MPRIS requires microseconds but we might not want to be that specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the behavior of the rewind/"previous song" action to match convention and official Spotify clients.
With this patch applied, rewinding will only jump to the previous track if the current track has been playing for no more than 2 seconds. Otherwise, playback simply seeks to the start of the current track.
Notes:
PositionMicrosdefinition andimpls from the MPRIS code; you could definitely hoist them out of their respective modules and avoid the duplication, but I figured it would be alright - rule of three and all that.Loadevent or the difference between aSeekand aSyncSeek, so there might be a logic error lurking in there.