Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove the broken release 1.0.17 #1734

Closed
yurivict opened this issue Feb 7, 2020 · 2 comments
Closed

Please remove the broken release 1.0.17 #1734

yurivict opened this issue Feb 7, 2020 · 2 comments
Labels

Comments

@yurivict
Copy link
Contributor

yurivict commented Feb 7, 2020

The 'install' target is broken: #1596

You shouldn't release until this is fixed. You make all port maintainers to try to build and to discover this problem.

@yurivict yurivict added the bug label Feb 7, 2020
@nicegamer7
Copy link

There is nothing wrong with the 1.0.17 release (at least on my end). In #1596, @LittleHuba says

For now do a make translations before building X++.

@Technius
Copy link
Member

Technius commented Feb 7, 2020

Oops, I guess I missed reverting f784631 when I backported changes to the 1.0.x series. I have updated the release description with a brief notice.

We're not going to pull the release because the translation target issue is a minor buildsystem issue. For now, you can either 1) patch po/CMakeLists.txt so it is compatible with your current build scripts:

-  gettext_create_translations ("${potfile}")
+  gettext_create_translations ("${potfile}" ALL)

or 2) modify your build scripts to run cmake --build . --target translations before running the install or package target.

Closing as a duplicate of #1596.

@Technius Technius closed this as completed Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants