Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strokes look different on canvas after release #82

Closed
wbrenna opened this issue Apr 6, 2014 · 2 comments
Closed

Strokes look different on canvas after release #82

wbrenna opened this issue Apr 6, 2014 · 2 comments
Labels

Comments

@wbrenna
Copy link
Contributor

wbrenna commented Apr 6, 2014

Maybe people can provide me with more details here. Certainly I have noticed Pango text is different - I believe that this is due to the rounding of font size to the DPI scale when the text box is unselected and becomes a xournalpp element. But I haven't seen this with strokes - on 64-bit systems the highlighter is not transparent while being drawn but I don't consider this to be a problem.

@andreasb242
Copy link
Contributor

The main reason for this is a performance reason. To make the highlighter look right you need to draw them on a separate image and put them with alpha to the main image.
If you paint multiple times to the screen, then its getting less and less transparent.
So I decided to write it non transparent to the screen.
(Performance was tested on a single core CPU, no complete redrawing was needed, but today it should be possible to redraw always the whole document)

The difference with text while editing is less than in Xournal ;-)

@andreasb242
Copy link
Contributor

Moved to GTK3 - and close because of age

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants