New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDPR infringement #78
Comments
Here is paragraph about Google Fronts and the data protection. (German Headline is -Google Fonts und die DSGVO) Is this the problem, that Google Fonts sents data to Google? I think there is a way to prevent this problem. |
Thanks for filing the issue, That said I think we have 2 options...
@xow do you have any preference? I'm thinking option 1 might be simplest. |
Hello, I don't think it is incompatible. The SIL Open Font Licence only says, that derivatives of the font must be published keeping the licence. This applies only, if you make a new font based on an existing one. If you just embed the font in your project, I don't think that this is a problem. https://fontsarena.com/licenses-explained/
Kind regards |
In regard of the text shared by @billieKnoll here is a translation based on deepl.com
|
I did a little research and yes from the official Google Font Webseite there is only the Open Font Licence https://fonts.google.com/specimen/Audiowide?query=aud#standard-styles |
I'm working on a patch that changes it over to one of the Google Fonts licensed under the Apache license. I'm currently testing using the font Arimo, but I haven't had a chance to determine if another one will be better. Once that's done I'll bundle it with the plugin. I'd rather make it work with an Apache Licensed font since it'll be GPL compatible. (I want to avoid future code checker issues as moodle requires items shipped with it to be GPL compatible) Once I have it fully tested, I'll roll it into the patchset for the Moodle 4.0 plugin release. (PR #77) |
Addresses Issue xow#78 by serving the fonts from the plugin instead of Google. Changes the font from Audiowide to Arimo for GPL license compatibility.
I've put together a patch that seems to address the issue. If you can give it a try, it would be appreciated. At the moment it's available on the build for Moodle 4.0 which you can get here: https://github.com/sbourget/moodle-mod_quizgame/tree/MOODLE_40_FIXES Thanks! |
Hello, As regards the technical implementation, I think it solves the problem. I saw that you switched from Audiowide to Arimo. Audiowide was better suiting the graphical requirements of this game. I did a little research and came across this information from the SIL OFL: https://scripts.sil.org/cms/scripts/page.php?item_id=OFL-FAQ_web#68092c0f It says:
I think you can safely ship Audiowide with this plugin! Kind regards |
PS: Maybe you should consider to set the Content-Type to text/css in the font.php. The content-type is text/html by default for a PHP-Script, so Webbrowsers may complain about it. Just add
|
Thanks all, My concern with audiowide was over the licensing as Moodle had this requirement for the Plugin DB https://docs.moodle.org/dev/Plugin_contribution_checklist#Licensing That said, I just found that Moodle Core is shipping with a SIL OFL licensed library, so there shouldn't be an issue moving back to audiowide: https://github.com/moodle/moodle/blob/master/lib/thirdpartylibs.xml#L268 I'll work on an updated patch later today. |
The Patch has been updated and available here: https://github.com/sbourget/moodle-mod_quizgame/tree/MOODLE_40_FIXES Please test. |
Hello, I am sorry, I will not be able to test this before February 15th. Kind regards |
Is there a particular reason why it is only designed to work with Modle 4.0? It is still not released yet... |
In Moodle 4 it works. I also tried in Moodle 3.11, but I received errors:
|
I've been working on the changes for Moodle 4.0 that is why I've rolled it into that release. I can back-port it into the Moodle 3.11 release later if needed. AS for the MOD_PURPOSE, that is part of the Moodle 4.0 Navigation overhaul see: https://tracker.moodle.org/browse/MDL-71457. There is also an API change for the question bank so the 4.0 branch will not work on Moodle 3.11 |
Hello, yes, please back-port this patch into the Moodle 3.11 version of your Plugin. Although we wanted to switch to Moodle 4.0 this summer, due to the delay of the release plan (originally November 2021, now March 2022), we decided to wait one year. Therefore we will stick with our platform to Moodle 3.11 until 2023 and will then switch to the LTS version 4.1. I think, also other educational institutions will wait to upgrade. It is uncertain, if all third party plugins will be compatible to Moodle 4.0 already this summer! Kind regards Robert |
Thanks @sbourget sorry I missed this conversation, my github notifications must be misconfigured |
Hello,
we recognized, that mod_quizgame imports Google Fonts in
moodle-mod_quizgame/view.php
Line 91 in b5ba519
As for European sites, this causes an infringement of the GDPR. Would it be possible to offer a localized version of the Google fonts integrated in your plugin?
Kind regards
The text was updated successfully, but these errors were encountered: