Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test display #3

Merged
merged 1 commit into from Sep 17, 2018
Merged

Fix test display #3

merged 1 commit into from Sep 17, 2018

Conversation

thekid
Copy link
Member

@thekid thekid commented Sep 16, 2018

The HTML report currently always displays 1 test covers line ... and the string "test" here:

image

@thekid thekid added the bug Something isn't working label Sep 16, 2018
Copy link
Member Author

@thekid thekid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

@@ -60,7 +60,9 @@ public function __construct() {
* @param unittest.TestCase failure
*/
public function testStarted(TestCase $case) {
// Empty
$this->covering && $this->coverage->stop();
$this->coverage->start($case->getName(true));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what the id parameter is for: To hold a reference to the testcase 😀

@OlafSeng OlafSeng merged commit 9fe219a into master Sep 17, 2018
@thekid thekid deleted the fix/tests branch September 17, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants