Fix com.handlebarsjs.PartialNode string representation

xp-forge · Oct 28, 2023 · f9c9db7 · f9c9db7
1 parent 3438780
commit f9c9db7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -3,6 +3,10 @@ HandleBars change log
 
 ## ?.?.? / ????-??-??
 
+* Fixed `com.handlebarsjs.PartialNode` string representation to include
+  closing braces
+  (@thekid)
+
 ## 9.2.0 / 2013-10-22
 
 * Added support for literals enclosed in `[]` - @thekid

diff --git a/src/main/php/com/handlebarsjs/PartialNode.class.php b/src/main/php/com/handlebarsjs/PartialNode.class.php
@@ -64,7 +64,7 @@ protected function optionString() {
    * @return string
    */
   public function toString() {
-    return nameof($this).'{{> '.$this->template->toString().$this->optionString().'}}, indent= "'.$this->indent.'"';
+    return nameof($this).'(> '.$this->template->toString().$this->optionString().'}}, indent= "'.$this->indent.'")';
   }
 
   /**

diff --git a/src/test/php/com/handlebarsjs/unittest/PartialNodeTest.class.php b/src/test/php/com/handlebarsjs/unittest/PartialNodeTest.class.php
@@ -14,13 +14,14 @@ public function template() {
 
   #[Test]
   public function string_representation() {
-    $partial= new PartialNode(new Lookup('test'));
-    Assert::equals('com.handlebarsjs.PartialNode{{> com.handlebarsjs.Lookup(test)}}, indent= ""', $partial->toString());
+    Assert::equals(
+      'com.handlebarsjs.PartialNode(> com.handlebarsjs.Lookup(test)}}, indent= "")',
+      (new PartialNode(new Lookup('test')))->toString()
+    );
   }
 
   #[Test]
   public function string_cast() {
-    $partial= new PartialNode(new Lookup('test'));
-    Assert::equals('{{> test}}', (string)$partial);
+    Assert::equals('{{> test}}', (string)new PartialNode(new Lookup('test')));
   }
 }