Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for xp-forge/web ^4.0 applications, which provide an initializer #12

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

thekid
Copy link
Member

@thekid thekid commented Jan 30, 2024

));

// Check for `xp-forge/web ^4.0` applications, which provide an initializer
if ($routes instanceof Application && method_exists($routes, 'initialize')) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method_exists check can be dropped when upgrading this library's dependencies to support xp-forge/web ^4.0. Currently, we support 3.0 and 4.0-SERIES:

@thekid thekid added the enhancement New feature or request label Jan 30, 2024
@thekid thekid merged commit 4a782f6 into main Jan 30, 2024
20 checks passed
@thekid thekid deleted the feature/app-initialization branch January 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant