Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric Literal Separator #61

Closed
thekid opened this issue Jun 14, 2019 · 1 comment
Closed

Numeric Literal Separator #61

thekid opened this issue Jun 14, 2019 · 1 comment
Labels
enhancement good first issue
Projects
PHP 7.4

Comments

@thekid
Copy link
Member

thekid commented Jun 14, 2019 

$threshold = 1_000_000_000;  // a billion!
$testValue = ‪107_925_284.88; // scale is hundreds of millions
$discount = 135_00;          // $135, stored as Cents

See https://wiki.php.net/rfc/numeric_literal_separator
@thekid thekid added this to TODO in PHP 7.4 Jun 14, 2019
@thekid thekid moved this from TODO to In progress in PHP 7.4 Jun 14, 2019
thekid added a commit that referenced this issue Jun 14, 2019
@thekid
Implement numeric literal separator, e.g. 1_000_000_000 - see #61
bf8b7bc
@thekid
Copy link
Member Author

thekid commented Jun 14, 2019

Tests are now green - see https://travis-ci.org/xp-framework/compiler/builds/545891219

@thekid thekid closed this as completed Jun 14, 2019
PHP 7.4 automation moved this from In progress to Done Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
No open projects
PHP 7.4
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thekid