Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to new PHP annotation syntax #86

Closed
3 tasks done
thekid opened this issue Jul 5, 2020 · 6 comments
Closed
3 tasks done

Adjust to new PHP annotation syntax #86

thekid opened this issue Jul 5, 2020 · 6 comments

Comments

@thekid
Copy link
Member

thekid commented Jul 5, 2020

Use #[...] instead of << >>, see https://wiki.php.net/rfc/shorter_attribute_syntax

  • Support both in the first step in a patch level release
  • Add an E_DEPRECATED warning to << >> syntax in order to make unittests fail but production code work in next minor release
  • Remove support for << >> in next major release
@thekid
Copy link
Member Author

thekid commented Jul 12, 2020

Initial syntactic support added to xp-framework/ast xp-framework/ast#7 though still missing inline attributes and support for multiple arguments

@thekid
Copy link
Member Author

thekid commented Jul 19, 2020

The pull request xp-framework/ast#7 can now be merged; and the dependency updated accordingly.

@thekid
Copy link
Member Author

thekid commented Jul 20, 2020

1️⃣ First step released in https://github.com/xp-framework/compiler/releases/tag/v5.2.0

@thekid
Copy link
Member Author

thekid commented Sep 29, 2020

2️⃣ With named arguments support in https://github.com/xp-framework/compiler/releases/tag/v5.3.0, we can now support rewriting annotations to more idiomatic PHP

@thekid
Copy link
Member Author

thekid commented Sep 29, 2020

3️⃣ With xp-framework/ast#9 merged, deprecation notices will be emitted (but production code continues to work!)

@thekid
Copy link
Member Author

thekid commented Oct 1, 2020

4️⃣ Released officially along with https://github.com/xp-framework/compiler/releases/tag/v5.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant