Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File name format #129

Closed
jmbai2000 opened this issue Aug 1, 2018 · 8 comments
Closed

File name format #129

jmbai2000 opened this issue Aug 1, 2018 · 8 comments

Comments

@jmbai2000
Copy link

jmbai2000 commented Aug 1, 2018

I think we should change the format of the chi files saved by the streamline.
1, we should add a reasonable scale factor so that y-column has no numbers less than 1. Since most data processing programs will take the y-column as number of counts, with the too low normalized counts, there will be artificial steps showing in the plot. (see attached plot) Actually I don’t think the normalization is necessary at all.
2, the texts before the data columns should all start with #, so that the data processing program will ignore them when plot the data. Right now the Jade program cannot read the chi files unless we manually remove the headlines.
3, add some more meaningful information in the headline, such as wavelength and sample-detector distance. Please compare the chi file and the xy file given by Dioptas. I don’t see why we need to add in every data file these lines “This file contains integrated powder x-ray diffraction intensities. First column represents two theta values (degrees) and second column represents intensities and if there is a third column it represents the error values of intensities.”
4, It is crazy to keep 20 digits in the data columns, in the scientific numerical format, 10 is more than enough.

@CJ-Wright
Copy link
Member

@jmbai2000 Thank you very much for reporting!

@CJ-Wright
Copy link
Member

The current .chi saving capability is from scikit-beam which is maintained by the DAMA group. Do you mind if I open an issue at that repo with the problems your raised here?

@jmbai2000
Copy link
Author

jmbai2000 commented Aug 1, 2018 via email

@sbillinge
Copy link
Member

I will close this issue, as it is now a scikit beam issue. Thanks for posting that @CJ-Wright

@jmbai2000 , please follow up with the DAMA group for next steps.

S

@jmbai2000
Copy link
Author

jmbai2000 commented Aug 15, 2018 via email

@CJ-Wright
Copy link
Member

@jmbai2000 can you please open a new issue for this?

@jmbai2000
Copy link
Author

jmbai2000 commented Aug 16, 2018 via email

@CJ-Wright
Copy link
Member

Yes, I have, sorry I've been a bit bogged down rn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants