fixed deprecation crash (passing null to json_decode()) #82
Conversation
| $metadata = empty($content) ? [] : json_decode($content, true); | ||
| return $metadata; |
There was a problem hiding this comment.
IMHO we still need the return $metadata ?? [] in case json_decode fails somehow
There was a problem hiding this comment.
but the crash occurs in 123... the execution stops before the ternary can be called...
PHP 8.2.15
There was a problem hiding this comment.
I didn't say the rest of the patch didn't look good :)
There was a problem hiding this comment.
What do you mean? :D
I meant that the original line 123 crashed, before the ternary can choose something ^^
There was a problem hiding this comment.
I mean that if somehow $content is not empty and CANNOT be properly decoded as JSON, then the second part of the ternary with the json_decode you use will put something that is not an array into $metadata, thus the return statement should (still) take care of that imho.
There was a problem hiding this comment.
the function json_decode() can't use NULL as first parameter... at least PHP 8.2.15.. so if $content is NULL in 123, the execution stops... no matter what happens afterwards...
You cannot pass NULL to json_decode anymore... this prevents the file from being uploaded by using for example StorageRepository->addFile()