You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The if is always false. You are checking that extra_xpra_args is not None which is impossible since that variable is initialized as [] which python considers it different than None and it never is assigned to None.
The problem with this is that the very next line is the only place where command_argv can be filled (unless you split the command with --) rendering impossible to fill.
the message of missing command is printed and the program exits as failure.
This is clearly an error, and I would gladly make a pull request but I have no idea about the intention behind that if so I thought it would be better to report this as an issue.
Also some people might argue that since the cli can be ussed splitting the argument with -- is not a problem, but the usage message mentions nothing about it.
* fix and simplify command line parsing when [not] splitting,
* modernize code
* handle missing imports more gracefully (ie: the 'xpra' command may use a different Python interpreter, Gtk may not be available either)
* add more usage examples
In
xpra/fs/bin/run_scaled
Lines 89 to 90 in 90f6ae4
The if is always false. You are checking that
extra_xpra_args
is notNone
which is impossible since that variable is initialized as[]
which python considers it different thanNone
and it never is assigned toNone
.The problem with this is that the very next line is the only place where
command_argv
can be filled (unless you split the command with--
) rendering impossible to fill.Because of this, always at
xpra/fs/bin/run_scaled
Lines 93 to 94 in 90f6ae4
the message of missing command is printed and the program exits as failure.
This is clearly an error, and I would gladly make a pull request but I have no idea about the intention behind that
if
so I thought it would be better to report this as an issue.Also some people might argue that since the cli can be ussed splitting the argument with
--
is not a problem, but the usage message mentions nothing about it.xpra/fs/bin/run_scaled
Lines 11 to 16 in 90f6ae4
The text was updated successfully, but these errors were encountered: