PBKDF2 해시 생성시 솔트의 엔트로피 개선 #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBKDF2 해시 생성에 사용되는 솔트가 16진수(
0-9,a-f)로 인코딩되어 있어서 엔트로피가 글자당 4비트밖에 되지 않습니다. 안 그래도 DB의 비번 컬럼 길이 제한 때문에 솔트를 12글자로 줄여 쓰고 있는데... 총 48비트는 좀 그렇네요 ㅡ.ㅡ;; (bcrypt의 솔트는 무려 128비트입니다.)그래서 솔트 생성 포맷을
alnum으로 바꾸어 글자당 6비트, 총 72비트의 엔트로피를 가지도록 수정합니다. 원래 이렇게 쓰는 게 정상인데 어딘가에서 실수가 있었던 것 같네요. (createSecureSalt()메소드의 기본값을 바꿔놓고 잊어버린 듯...)