fix #2290 관리자가 회원 메모를 삭제할수 없는 문제 수정 #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrambo
reviewed
Aug 29, 2018
modules/member/member.controller.php
Outdated
| if(!$args->description) $args->description = $orgMemberInfo->description; | ||
|
|
||
| // BUGFIX 관리자가 회원 메모를 삭제할수 없는 문제 수정 https://github.com/xpressengine/xe-core/issues/2290 | ||
| if(!isset($args->description)) $args->description = $orgMemberInfo->description; |
There was a problem hiding this comment.
결국은 기존 내용을 그대로 비슷하게 검사하는 것으로 보여집니다.
그냥 isset으로 내용이 설정이 안되어있다면 내용을 null으로 만들어서 빈값으로 들어가도록 하는것은 어떤가요?
There was a problem hiding this comment.
@bjrambo XML 쿼리에서는 null을 넣으면 아예 해당컬럼을 UPDATE문에서 빼버리지 않나요?
There was a problem hiding this comment.
@kijin 아.. 그렇네요.. 시리얼라이즈 스트링으로 만든 값을 저장하는 방식이랑 착각 했습니다.. 어찌되었던 빈 스트링값이라도 넘겨야할것 같아요.
ghost
self-assigned this
YJSoft
changed the title
관리자 화면에서 회원 메모를 비우면 NULL이 넘어와 기존값이 사용되는 문제점 고침
YJSoft
changed the title
ghost
merged commit
ghost
mentioned this pull request
dorami
added a commit
to daolcms/daolcms
that referenced
this pull request
Oct 11, 2018
dorami
added a commit
to daolcms/daolcms
that referenced
this pull request
Oct 13, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관리자가 회원 메모를 비우면 NULL이 넘어가서 메모가 변경되지 않는 문제점을 수정합니다.