Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon 등록 실패 문제 해결. #725

Merged
merged 2 commits into from
May 26, 2014
Merged

favicon 등록 실패 문제 해결. #725

merged 2 commits into from
May 26, 2014

Conversation

ppiyakk2
Copy link

ico 파일을 올리게 되면 type 으로 "image/vnd.microsoft.icon" 가 설정되기 때문에 .ico 가 아닌 .icon 으로 해야한다.

@akasima akasima added this to the 1.7.5.1 milestone May 23, 2014
@akasima akasima self-assigned this May 23, 2014
akasima added a commit that referenced this pull request May 26, 2014
favicon 등록 실패 문제 해결.
@akasima akasima merged commit b1edfde into xpressengine:develop May 26, 2014
@sergeiten
Copy link
Contributor

There is still problem with changing favicon ever if I update my XE to 1.7.5.1 version.

Checking of MIME type of ico file still can't pass this condition in modules/install/install.admin.controller.php file (~338 line).

if(!preg_match('/^.*\.icon$/i',$type)) {
    Context::set('msg', '*.ico '.Context::getLang('msg_possible_only_file'));
    return;
}

There is a checking for dot symbol in regex, but there is no any dots symbols in MIME type of favicon file. Possible solution is:

if(!preg_match('/^.*icon$/i',$type)) {
    Context::set('msg', '*.ico '.Context::getLang('msg_possible_only_file'));
    return;
}

btw. I think there should be error message that name of favicon file HAS TO BE "favicon.ico", the same for "mobicon.png".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants