Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router class 개선 및 오류 수정 #914

Merged
merged 4 commits into from
Aug 20, 2014
Merged

Router class 개선 및 오류 수정 #914

merged 4 commits into from
Aug 20, 2014

Conversation

smaker
Copy link
Contributor

@smaker smaker commented Aug 16, 2014

  • RewriteRule의 break 문법 지원
    • Apache RewriteRule의 [L] 플래그
    • Nginx RewriteRule의 break 문법
  • 성능 이슈 및 deprecated 이슈로 preg_replace() 대신에 substr_compare() 함수와 substr() 함수를 이용하여 동작하도록 개선
    • ps. preg_replace() 함수의 /e modifier가 PHP 5.5에서 deprecated 처리됨
  • URI Segment가 1개인 경우 Segment 정보를 가져오지 못하던 오류 수정

- RewriteRule의 break 문법 지원
-- Apache RewriteRule의 [L] 플래그
-- Nginx RewriteRule의 break 문법

-성능 이슈 및 deprecated 이슈로 preg_replace() 대신에 substr_compare() 함수와 substr()
함수를 이용하여 동작하도록 개선

ps. preg_replace() 함수의 /e modifier가 PHP 5.5에서 deprecated 처리됨

- URI Segment가 1개인 경우 해당 Segment를 Unset 하던 오류 수정
@bjrambo
Copy link
Contributor

bjrambo commented Aug 16, 2014

👍

1 similar comment
@YJSoft
Copy link
Contributor

YJSoft commented Aug 17, 2014

👍

@akasima akasima added this to the 1.8.0 milestone Aug 20, 2014
akasima added a commit that referenced this pull request Aug 20, 2014
Router class 개선 및 오류 수정
@akasima akasima merged commit d0a7872 into xpressengine:develop Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants