Update specification_service.go to not fail sometimes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was assumed that every device image was contained in an <a> element. However, that's sometimes not the case ([two](https://www.gsmarena.com/acer_iconia_one_8_b1_820-7217.php) [times](https://www.gsmarena.com/acer_betouch_t500-3587.php) in the first brand alone). This file change removes the assumption, leading to those devices being detected properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was assumed that every device image was contained in an element. However, that's sometimes not the case (two times in the first brand alone).
This file change adds support for those devices by searching for just![]()
elements instead of ![]()
elements inside of elements.