Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: remove the readthedocs related content from dev docs #476

Merged
merged 5 commits into from May 30, 2023

Conversation

shark-21
Copy link
Contributor

What do these changes do?

Removed readthedocs related documentation from /doc/source/development/contributing_documentation.rst

Related issue number

Fixes #464

@XprobeBot XprobeBot added the documentation Improvements or additions to documentation label May 28, 2023
@XprobeBot XprobeBot added this to the v0.3.2 milestone May 28, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #476 (1ae3e09) into main (b131507) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   93.60%   93.61%           
=======================================
  Files         997      997           
  Lines       77324    77324           
  Branches    16065    16065           
=======================================
+ Hits        72379    72383    +4     
+ Misses       3312     3304    -8     
- Partials     1633     1637    +4     
Flag Coverage Δ
unittests 93.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

qianduoduo0904
qianduoduo0904 previously approved these changes May 29, 2023
Copy link
Contributor

@qianduoduo0904 qianduoduo0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@UranusSeven UranusSeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution :)

Copy link
Contributor

@qianduoduo0904 qianduoduo0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit c1a9171 into xorbitsai:main May 30, 2023
28 of 29 checks passed
@shark-21 shark-21 deleted the remove-readthedocs-content branch May 30, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: remove the readthedocs related content from dev docs
4 participants