Attempt to restore the schema changes from PR 124 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xml-project
approved these changes
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema changes from PR #124 were accidentally lost. This PR applies a slightly different set of changes to achieve the same purpose.
Now that we allow p;variable in between steps, I think it's a mistake to allow it inside p:choose as a sibling of p:when/p:otherwise. A user can simply put it before the choose if they want it to be available to all of the conditional branches.
I chose a slightly different content model that makes it clear that at least one of p:when or p:otherwise is required.
Hopefully this is seen as a friendly amendment to the original PR.