Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 version of X-PSI! [WIP, do not merge!] #49

Closed
wants to merge 21 commits into from

Conversation

dhuppenkothen
Copy link
Contributor

Here's a Python3 version of X-PSI. I've been running it on python 3.9, with the latest versions of the relevant libraries supplied by conda, and installed it following the X-PSI installation instructions.

The modeling notebook seems to run without errors, but of course, I can't be 100% sure that there aren't still bugs in there. I think it's ready for some testing by someone who knows more about X-PSI than me and uses it for a wider range of purposes. So please go ahead, and report any weirdnesses and bugs you might run into!

@dhuppenkothen dhuppenkothen mentioned this pull request Sep 19, 2022
@dhuppenkothen
Copy link
Contributor Author

Current Conda environment file I've been using for development:
xpsi_py3_specfile.txt

@thjsal
Copy link
Contributor

thjsal commented Oct 12, 2022

Looks like the latest merge with current X-PSI code caused an indentation problem in line 67 of _postprocessor.py. There seems to be line which is intended using tab instead of spaces, and apparently Python2 did not complain about that.

  File "/home/tuomo/anaconda2/envs/xpsi_py3/lib/python3.10/site-packages/xpsi-0.7.12-py3.10-linux-x86_64.egg/xpsi/PostProcessing/_postprocessor.py", line 67
    self.samples={}
TabError: inconsistent use of tabs and spaces in indentation

By the way, I am here using still anaconda2, since it seems it can be also used to create Python3 environment. Or is there a reason to change to anaconda3?

@dhuppenkothen
Copy link
Contributor Author

Closing this to open a new PR from the dhuppenk_py3 branch within the XPSI repo itself rather than the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants