Game library #37
Game library #37
Conversation
Adds game library like feature to the GUI. File format detection per title based on magic numbers instead of file extension. Caches file format results.
| class DiscImageFormat(object): | ||
| XISO = 'XISO' | ||
| ISO9660 = 'ISO9660' | ||
| Unknown = 'Unknown format' |
There was a problem hiding this comment.
This should only act as an enum (ideally not used for display), so a number or unique identifer is better.
"Unknown format" is neither of these.
| def setDirectory(self, obj): | ||
| options = QFileDialog.Options() | ||
| directory = QFileDialog.getExistingDirectory(self, | ||
| "Select DVD Directory", |
There was a problem hiding this comment.
nit: not only "DVD", but "Optical Disc Image", poor wording though. I'd probably pick "CD / DVD Image" or something.
| @@ -206,7 +286,7 @@ def genArg(settings, name, port): | |||
| return args | |||
|
|
|||
| @staticmethod | |||
| def generateLaunchCmd(settings, skipPathChecks=False): | |||
| def generateLaunchCmd(settings, main, skipPathChecks=False): | |||
There was a problem hiding this comment.
This is ugly. Why does it need full access to the main object? Isn't it enough to pass the path to the DVD image?
Generally, I believe we'll probably (eventually) have some "virtual-xbox" state object, which basically says: "boot a virtual-xbox, which was left in this condition: revision 1.0, 128MB, bios flashed with XYZ, Halo disc in DVD tray, ..." (so a combination of settings and - possibly - user input).
| @@ -274,8 +355,8 @@ def launchCmdToString(cmd): | |||
|
|
|||
| return ' '.join(cmd_escaped) | |||
|
|
|||
| def start(self, settings): | |||
| cmd = self.generateLaunchCmd(settings) | |||
| def start(self, settings, main): | |||
There was a problem hiding this comment.
Same as for generateLaunchCmd. Information hiding etc.
| @@ -344,9 +425,12 @@ def __init__(self, *args): | |||
| self.inst = Xqemu() | |||
| self.settings = SettingsManager() | |||
| self.settings.load() | |||
| self.runButton.setText('Start') | |||
| self.pauseButton.setText('Pause') | |||
| self.screenshotButton.setText('Screenshot') | |||
There was a problem hiding this comment.
Where did this (or equivalent) move?
There was a problem hiding this comment.
Its not necessary as far as i can tell since the text will be set after launch due to the .ui files anyway
There was a problem hiding this comment.
@mborgerson why was this done? Localization or something? Or just accidentally?
| self.gamesCache = [] | ||
|
|
||
| # Disable resizing because it doesnt really do anything | ||
| self.setFixedSize(540, 293) |
There was a problem hiding this comment.
Disabling resizing isn't an option in my opinion.
This looks like a cruel hack, rather than good UI design.
| for title in files: | ||
| filepath = self.settings.settings['dvd_folder_path'] + '/' + title | ||
| cached = self.libraryCache.checkExisting(filepath) | ||
| # This should fetch pmuch all infos from cache if possible |
|
|
||
| SETTINGS_FILE = './settings.json' | ||
| LIBRARY_CACHE = './library.cache' |
There was a problem hiding this comment.
Regardless of the file format we eventually choose, give this a proper extension (.csv / .json).
|
Rejected due to lack of progress / incompleteness. We kept going back and forth about this on Discord when this PR was fresh, because there's some design limitations for LLE. As for the major GUI changes / game-selection, we suggest to consult XQEMU maintainers. Closed. |
Adds game library like feature to the GUI.
File format detection per title based on magic numbers instead of file extension.
Caches file format results.