Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xiso check on disc images #220

Closed
LittleStinky123 opened this issue May 11, 2019 · 3 comments
Closed

Add xiso check on disc images #220

LittleStinky123 opened this issue May 11, 2019 · 3 comments

Comments

@LittleStinky123
Copy link

At the moment xqemu only checks if the disk image exists.
If it can't be opened after the vm booted up, for example if it is a backup made with a kreon drive, there is no error message displayed.
Adding a check for that would be nice as there isn't anything of the iso format mentioned on the official website.

@GXTX
Copy link
Contributor

GXTX commented May 11, 2019

Redump style ISOs being broken is just a bug (#37), and you are free to put any type of disk into your real Xbox, why not XQEMU?

@LittleStinky123
Copy link
Author

Sorry, I didn't know they were called redump isos.
Then I would have probably found the issue and wouldn't have opened this one.

@JayFoxRox
Copy link
Member

JayFoxRox commented May 11, 2019

This repository is for the Xbox hardware emulation. As @GXTX correctly said: a hardware drive does not check if the disc you insert is correctly formatted.

XQEMU is not making any assumptions about how you'd use your virtual Xbox hardware.
This is similar to what would happen if you inserted a burned CD into a real Xbox: the running OS will choose how to signal the error. This should not be the emulators responsibility (which attempts to remain neutral / not be invasive; especially with LLE).

You should have the ability to insert an audio-CD, a video DVD, a data DVD, or any other kind of disc medium (different sizes / different filesystems / ...) into your physical or virtual Xbox. And XQEMU allows this.
This would also be expected by some Xbox applications, Linux or reactOS. Adding too many Xbox constraints to the hardware layer would be bad.

We did discuss a warning for users, and this can be acceptable (if it's only a warning); but it would belong into the GUI, which is currently mostly in https://github.com/xqemu/xqemu-manager/ . Some work of disc identification has been done in this code of PR 37 (which is likely to be rejected for other reasons).

Closed (belongs into UI / not suitable for LLE).


As for broken redump support: this is #37 but also #26 . It's a lack of DVD drive copy protection emulation (the documentation is also lacking, and that's xqemu/xqemu.com#24).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants