Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEATHER] Update weather system/levels (af3 + AN) #105

Merged
merged 24 commits into from
May 29, 2024
Merged

[WEATHER] Update weather system/levels (af3 + AN) #105

merged 24 commits into from
May 29, 2024

Conversation

Neloreck
Copy link
Member

@Neloreck Neloreck commented May 16, 2024 •
edited

Changes

  • Updated weather system to use atmosfear3 (customized, no settings menu)
  • Updated assets to use absolute nature mod for levels
  • Removed old weather management
  • Updated shader presets to work with AF3
  • Alternative start position -> original start position extension
  • Removed unused utils / tests updated and generic fixes

Checklist

  • tests are included
  • documentation is changed or added

@Neloreck
Added af3 weather configs.
32b5613 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Log more details related to npc sounds.
55e0b91 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Add resolving logs for dialog_ registrators.
250f200 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
New utils added / remove unused utils.
4d745d7 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Add new variant of weather system based on af3.
cb36bd5 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Update xrf resources module.
706ecf3 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck Neloreck self-assigned this May 16, 2024
@github-actions github-actions bot added cli Changes are affecting XRF cli tools test Changes are updating or introducing unit tests managers Changes are affecting game managers scripts configs Changes are affecting ltx configuration labels May 16, 2024
@Neloreck
Corrected circular loops. Define ltx schemes for some weather configs.
5158dcc 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Updated submodule with xrf utils.
36244bb 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Weather schemes for [default].
86cc62f 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Fix ternary condition.
9f15124 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@github-actions github-actions bot added the extensions Changes are affecting custom extensions label May 17, 2024
@Neloreck
Cross-platform path read for ini mock.
69d4cdd 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck Neloreck changed the title [WEATHER] Update weather system to be similar to af3 [WEATHER] Update weather system to be similar to af3 + AN May 17, 2024
@Neloreck
Add tracing logs for debug of CI failure.
cd1321c 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Update resources module to include AN assets.
65da2b7 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Trace more path variants.
b118ff0 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Update normalize path util.
abb1e37 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.36%. Comparing base (a098bb8) to head (b22d912).

❗ Current head b22d912 differs from pull request most recent head 4f0c22a

Please upload reports for the commit 4f0c22a to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   72.25%   72.36%   +0.11%     
==========================================
  Files        1291     1293       +2     
  Lines       36485    36650     +165     
  Branches     6222     6245      +23     
==========================================
+ Hits        26362    26522     +160     
- Misses      10123    10128       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neloreck
Tests for generic level utils.
6f2bc04 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Add weather_dof tests.
f403bcb 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Simplification and renaming.
6ea1048 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Removed storms functionality.
9cfdc3b 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Add atmosfear default configs / correct shader presets switching.
d6c227a 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Smaller plane distance for better performance.
e34aafd 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Tests update.
1141275 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck
Reformat LTX.
b22d912 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck Neloreck marked this pull request as ready for review May 29, 2024 01:48
@Neloreck
Update xrf tools.
4f0c22a 
Signed-off-by: Neloreck <Neloreck@gmail.com>
@Neloreck Neloreck changed the title [WEATHER] Update weather system to be similar to af3 + AN [WEATHER] Update weather system/levels (af3 + AN) May 29, 2024
@Neloreck Neloreck merged commit 5e31f59 into main May 29, 2024
11 checks passed
@Neloreck Neloreck deleted the dev-weather-atmosfear3 branch May 29, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Neloreck Neloreck

Labels
cli Changes are affecting XRF cli tools configs Changes are affecting ltx configuration extensions Changes are affecting custom extensions managers Changes are affecting game managers scripts test Changes are updating or introducing unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Neloreck