Skip to content

Commit

Permalink
Do not release IAudioProcessor
Browse files Browse the repository at this point in the history
This change matches behavior of Musec. It prevents crashes but might introduce
memory leaks.
  • Loading branch information
xris1658 committed Mar 11, 2024
1 parent b5d98b4 commit 941119b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/audio/plugin/VST3Plugin.cpp
Expand Up @@ -303,7 +303,6 @@ bool VST3Plugin::uninitialize()
eventProcessor_.reset();
resetProcessData();
clearAudioRelatedInfo();
releasePointer(audioProcessor_);
uninitializeEditController();
if(component_->terminate() == Steinberg::kResultOk)
{
Expand Down

1 comment on commit 941119b

@xris1658
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found out that Musec WILL release IAudioProcessor. However, this commit DOES prevent crashes when destroying some plugins.

Please sign in to comment.