Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pROC 1.12.0 cannot deal with large datasets any longer #29

Closed
xrobin opened this issue May 6, 2018 · 1 comment
Closed

pROC 1.12.0 cannot deal with large datasets any longer #29

xrobin opened this issue May 6, 2018 · 1 comment

Comments

@xrobin
Copy link
Owner

@xrobin xrobin commented May 6, 2018

Describe the bug
This is a regression due to the fix in #25

To Reproduce

> response <- rbinom(1E5, 1, .5)
> predictor <- rnorm(1E5)
> rocobj <- roc(response, predictor)
Erreur : impossible d'allouer un vecteur de taille 74.5 Go
4: outer(thresholds, predictor, `==`) at roc.utils.R#119
3: roc.utils.thresholds(c(controls, cases), direction) at roc.R#316
2: roc.default(response, predictor) at roc.R#21
1: roc(response, predictor)

This is caused by the check for identical values:

if (any(o <- outer(thresholds, predictor, `==`))) {

There must be an other way to test for exact equality between two vectors safely.

xrobin added a commit that referenced this issue May 6, 2018
xrobin added a commit that referenced this issue May 6, 2018
@xrobin
Copy link
Owner Author

@xrobin xrobin commented May 6, 2018

Fixed on master. Will push pROC 1.12.1 to CRAN ASAP.

@xrobin xrobin closed this May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.