Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Smoothing Feature to FOV Changes #163

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ELevin125
Copy link

Changes Made:

  • Updated the PIL Image scaling code to use the LANCZOS instead of ANTIALIAS, since it's outdated and throws errors.
  • Implemented a smooth transition feature for FOV changes, allowing the FOV to smoothly transition from the current FOV to the target FOV instead of snapping directly to it.
  • Added UI elements to control the smooth transition behavior. It can be toggled on and off, and the duration and steps can be changed.

@xroix
Copy link
Owner

xroix commented Jun 14, 2024

Sorry for answering so late! I am currently having my final exams. As soon as I get some more time on my hands, I'll look into merging your code and making a new release.

So far, your addition looks great! Thank you that you undertook the effort of adding a feature to this horrible codebase!

@SuperLlama88888
Copy link

I tried this out, it works fine. My only issue is that the linear transition feels unnatural. Perhaps a cubic bezier or exponential curve instead?

@SuperLlama88888
Copy link

Ok, I've done a bit more testing. Here are my observations:

  • When you set the duration to be high (e.g. 1 second) there is input delay at the start. The use of time.sleep also should be removed seeing that the Thread class is used elsewhere.
  • Stopping the app when it is transitioning to a new FOV causes a crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants