[Server] Prevent double unlock when open fails post file object creat…

…ion.
xrootd · Mar 14, 2018 · 2c27fbb · 2c27fbb
1 parent 453f2c5
commit 2c27fbb
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/XrdXrootd/XrdXrootdXeq.cc b/src/XrdXrootd/XrdXrootdXeq.cc
@@ -1193,12 +1193,14 @@ struct OpenHelper
                           : fp(0), xp(0), Locker(lkP), path(fn), mode(0),
                             isOK(false) {}
 
-                         ~OpenHelper() {if (!isOK)
-                                           {if (xp) delete xp;
-                                               else if (fp) delete fp;
+                         ~OpenHelper()
+                              {if (!isOK)
+                                  {if (xp) delete xp; // Deletes fp & unlocks
+                                      else {if (fp) delete fp;
                                             if (mode) Locker->Unlock(path,mode);
                                            }
-                                       }
+                                  }
+                              }
       };
 }