Skip to content

Commit

Permalink
xrootdfs: remove default fuse argument "allow_other" as it is impossi…
Browse files Browse the repository at this point in the history
…ble to unset

Motivation:
This prevented mounting if user_allow_other is not set in fuse.conf
So a user with no root access could not use xrootdfs and could not change this argument without recompiling.
Change:
Don't pass allow_other to fuse by default.
Result:
Now xrootdfs works if user_allow_other is disabled, and allow_other argument can be passed when mounting if it is needed.
  • Loading branch information
fizmat committed May 5, 2017
1 parent e521131 commit 5198c9c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/XrdFfs/XrdFfsXrootdfs.cc
Expand Up @@ -1233,7 +1233,7 @@ int main(int argc, char *argv[])
cmdline_opts = (char **) malloc(sizeof(char*) * (argc -1 + 3));
cmdline_opts[0] = argv[0];
cmdline_opts[1] = strdup("-o");
cmdline_opts[2] = strdup("fsname=xrootdfs,allow_other,max_write=131072,attr_timeout=10,entry_timeout=10,negative_timeout=5");
cmdline_opts[2] = strdup("fsname=xrootdfs,max_write=131072,attr_timeout=10,entry_timeout=10,negative_timeout=5");

for (int i = 1; i < argc; i++)
cmdline_opts[i+2] = argv[i];
Expand Down

0 comments on commit 5198c9c

Please sign in to comment.