[XrdSciTokens] Modifying std::map invalidates iterator

xrootd · Dec 13, 2021 · 5d165e1 · 5d165e1
1 parent d9c52f3
commit 5d165e1
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/XrdSciTokens/XrdSciTokensAccess.cc b/src/XrdSciTokens/XrdSciTokensAccess.cc
@@ -959,9 +959,11 @@ class XrdAccSciTokens : public XrdAccAuthorize, public XrdSciTokensHelper
         if (now <= m_next_clean) {return;}
         std::lock_guard<std::mutex> guard(m_mutex);
 
-        for (auto iter = m_map.begin(); iter != m_map.end(); iter++) {
+        for (auto iter = m_map.begin(); iter != m_map.end(); ) {
             if (iter->second->expired()) {
-                m_map.erase(iter);
+                iter = m_map.erase(iter);
+            } else {
+                ++iter;
             }
         }
         Reconfig();