[XrdCl] Allow to disable open retry logic.

docs/man/xrdcp.1

@@ -263,6 +263,11 @@ XRD_WRITERECOVERY
 Determines if write recovery should be enabled or disabled (enabled by default).
 .RE
 
+XRD_OPENRECOVERY
+.RS 5
+Determines if open recovery should be enabled or disabled for mutable (truncate or create) opens (enabled by default).
+.RE
+
 XRD_CONNECTIONWINDOW (-DIConnectionWindow)
 .RS 5
 A time window for the connection establishment. A connection failure is declared if

src/XrdCl/XrdClConstants.hh

@@ -79,6 +79,7 @@ namespace XrdCl
   const char * const DefaultPlugIn             = "";
   const char * const DefaultReadRecovery       = "true";
   const char * const DefaultWriteRecovery      = "true";
+  const char * const DefaultOpenRecovery       = "true";
   const char * const DefaultGlfnRedirector     = "";
 }
 

src/XrdCl/XrdClDefaultEnv.cc

@@ -299,6 +299,7 @@ namespace XrdCl
     REGISTER_VAR_STR( varsStr, "PlugInConfDir",        DefaultPlugInConfDir        );
     REGISTER_VAR_STR( varsStr, "ReadRecovery",         DefaultReadRecovery         );
     REGISTER_VAR_STR( varsStr, "WriteRecovery",        DefaultWriteRecovery        );
+    REGISTER_VAR_STR( varsStr, "OpenRecovery",         DefaultOpenRecovery         );
     REGISTER_VAR_STR( varsStr, "GlfnRedirector",       DefaultGlfnRedirector       );
 
     //--------------------------------------------------------------------------

src/XrdCl/XrdClXRootDMsgHandler.cc

@@ -1896,7 +1896,7 @@ namespace XrdCl
     }
     else
     {
-      if( !status.IsFatal() )
+      if( !status.IsFatal() && IsRetryable( pRequest ) )
       {
         HandleError( RetryAtServer( pUrl ) );
         return;
@@ -2080,4 +2080,36 @@ namespace XrdCl
 
     return;
   }
+
+  //------------------------------------------------------------------------
+  //! Check if it is OK to retry this request
+  //------------------------------------------------------------------------
+  bool XRootDMsgHandler::IsRetryable( Message *request )
+  {
+    std::string value;
+    DefaultEnv::GetEnv()->GetString( "OpenRecovery", value );
+    if( value == "true" ) return true;
+
+    // check if it is a mutable open (open + truncate or open + create)
+    ClientRequest *req = reinterpret_cast<ClientRequest*>( pRequest->GetBuffer() );
+    if( req->header.requestid == htons( kXR_open ) )
+    {
+      bool _mutable = ( req->open.options & htons( kXR_delete ) ) ||
+                      ( req->open.options & htons( kXR_new ) );
+
+      if( _mutable )
+      {
+        Log *log = DefaultEnv::GetLog();
+        log->Debug( XRootDMsg,
+                    "[%s] Not allowed to retry open request (OpenRecovery disabled): %s.",
+                    pUrl.GetHostId().c_str(),
+                    pRequest->GetDescription().c_str() );
+        // disallow retry if it is a mutable open
+        return false;
+      }
+    }
+
+    return true;
+  }
+
 }

src/XrdCl/XrdClXRootDMsgHandler.hh

@@ -375,6 +375,14 @@ namespace XrdCl
       //------------------------------------------------------------------------
       void HandleLocalRedirect( URL *url );
 
+      //------------------------------------------------------------------------
+      //! Check if it is OK to retry this request
+      //!
+      //! @param   reuqest : the request in question
+      //! @return          : true if yes, false if no
+      //------------------------------------------------------------------------
+      bool IsRetryable( Message *request );
+
       //------------------------------------------------------------------------
       // Helper struct for async reading of chunks
       //------------------------------------------------------------------------