[XrdCl] Try all IP addresses in case posix connect fails.

xrootd · Jan 17, 2018 · a9e2bfa · a9e2bfa
1 parent b63a244
commit a9e2bfa
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 10 deletions.
diff --git a/docs/man/xrdcp.1 b/docs/man/xrdcp.1
@@ -456,6 +456,11 @@ XRD_NODELAY
 Disables the Nagle algorithm if set to 1 (default), enables it if set to 0.
 .RE
 
+XRD_PREFERIPV4
+.RS 5
+If set the client tries first IPv4 address (turned off by default).
+.RE
+
 .SH NOTES
 Documentation for all components associated with \fBxrdcp\fR can be found at
 http://xrootd.org/docs.html

diff --git a/src/XrdCl/XrdClConstants.hh b/src/XrdCl/XrdClConstants.hh
@@ -69,6 +69,7 @@ namespace XrdCl
   const int DefaultXCpBlockSize         = 134217728; // DefaultCPChunkSize * DefaultCPParallelChunks * 2
   const int DefaultNoDelay              = 1;
   const int DefaultAioSignal            = 1;
+  const int DefaultPreferIPv4           = 0;
 
   const char * const DefaultPollerPreference   = "built-in";
   const char * const DefaultNetworkStack       = "IPAuto";

diff --git a/src/XrdCl/XrdClDefaultEnv.cc b/src/XrdCl/XrdClDefaultEnv.cc
@@ -289,6 +289,7 @@ namespace XrdCl
     REGISTER_VAR_INT( varsInt, "XCpBlockSize",         DefaultXCpBlockSize         );
     REGISTER_VAR_INT( varsInt, "NoDelay",              DefaultNoDelay              );
     REGISTER_VAR_INT( varsInt, "AioSignal",            DefaultAioSignal            );
+    REGISTER_VAR_INT( varsInt, "PreferIPv4",           DefaultPreferIPv4           );
 
     REGISTER_VAR_STR( varsStr, "PollerPreference",     DefaultPollerPreference     );
     REGISTER_VAR_STR( varsStr, "ClientMonitor",        DefaultClientMonitor        );

diff --git a/src/XrdCl/XrdClStream.cc b/src/XrdCl/XrdClStream.cc
@@ -240,7 +240,6 @@ namespace XrdCl
       return pLastFatalError;
 
     gettimeofday( &pConnectionStarted, 0 );
-    pConnectionInitTime = now;
     ++pConnectionCount;
 
     //--------------------------------------------------------------------------
@@ -265,12 +264,23 @@ namespace XrdCl
     // It's more efficient to remove addresses from the back of a vector
     // so we reverse the it.
     //--------------------------------------------------------------------------
-    std::reverse( pAddresses.begin(), pAddresses.end() );
-    pSubStreams[0]->socket->SetAddress( pAddresses.back() );
-    pAddresses.pop_back();
-    st = pSubStreams[0]->socket->Connect( pConnectionWindow );
-    if( st.IsOK() )
-      pSubStreams[0]->status = Socket::Connecting;
+    int preferIPv4 = DefaultPreferIPv4;
+    DefaultEnv::GetEnv()->GetInt( "PreferIPv4", preferIPv4 );
+    if( !preferIPv4 )
+      std::reverse( pAddresses.begin(), pAddresses.end() );
+
+    while( !pAddresses.empty() )
+    {
+      pSubStreams[0]->socket->SetAddress( pAddresses.back() );
+      pAddresses.pop_back();
+      pConnectionInitTime = ::time( 0 );
+      st = pSubStreams[0]->socket->Connect( pConnectionWindow );
+      if( st.IsOK() )
+      {
+        pSubStreams[0]->status = Socket::Connecting;
+        break;
+      }
+    }
     return st;
   }
 
@@ -676,12 +686,19 @@ namespace XrdCl
     //------------------------------------------------------------------------
     if( !pAddresses.empty() )
     {
-      pSubStreams[0]->socket->SetAddress( pAddresses.back() );
-      pAddresses.pop_back();
+      Status st;
+      do
+      {
+        pSubStreams[0]->socket->SetAddress( pAddresses.back() );
+        pAddresses.pop_back();
+        pConnectionInitTime = ::time( 0 );
+        st = pSubStreams[0]->socket->Connect( pConnectionWindow );
+      }
+      while( !pAddresses.empty() && !st.IsOK() );
 
-      Status st = pSubStreams[0]->socket->Connect( pConnectionWindow-elapsed );
       if( !st.IsOK() )
         OnFatalError( subStream, st, scopedLock );
+
       return;
     }
     //------------------------------------------------------------------------