[CMake] Replace setting blank link properties with private linking

Originally introduced in 220e15e to
prevent overlinking, setting an empty INTERFACE_LINK_LIBRARIES can now
be replaced with target_link_libraries with PRIVATE linking.

src/XrdApps.cmake

@@ -162,6 +162,7 @@ add_library(
 
 target_link_libraries(
   XrdAppUtils
+  PRIVATE
   XrdUtils )
 
 set_target_properties(
@@ -179,13 +180,7 @@ add_library(
   XrdApps/XrdClProxyPlugin/ProxyPrefixPlugin.cc
   XrdApps/XrdClProxyPlugin/ProxyPrefixFile.cc)
 
-target_link_libraries(${LIB_XRDCL_PROXY_PLUGIN} XrdCl)
-
-set_target_properties(
-  ${LIB_XRDCL_PROXY_PLUGIN}
-  PROPERTIES
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
+target_link_libraries(${LIB_XRDCL_PROXY_PLUGIN} PRIVATE XrdCl)
 
 #-------------------------------------------------------------------------------
 # XrdClRecorder library
@@ -195,13 +190,7 @@ add_library(
   MODULE
   XrdApps/XrdClRecordPlugin/XrdClRecorderPlugin.cc )
 
-target_link_libraries(${LIB_XRDCL_RECORDER_PLUGIN} XrdCl)
-
-set_target_properties(
-  ${LIB_XRDCL_RECORDER_PLUGIN}
-  PROPERTIES
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
+target_link_libraries(${LIB_XRDCL_RECORDER_PLUGIN} PRIVATE XrdCl)
 
 add_executable(
   xrdreplay

src/XrdCeph/src/XrdCeph.cmake

@@ -24,16 +24,15 @@ set_property(SOURCE XrdCeph/XrdCephPosix.cc
 
 target_link_libraries(
   XrdCephPosix
+  PRIVATE
   ${XROOTD_LIBRARIES}  
   ${RADOS_LIBS} )
 
 set_target_properties(
   XrdCephPosix
   PROPERTIES
   VERSION   ${XRD_CEPH_POSIX_VERSION}
-  SOVERSION ${XRD_CEPH_POSIX_SOVERSION}
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
+  SOVERSION ${XRD_CEPH_POSIX_SOVERSION} )
 
 #-------------------------------------------------------------------------------
 # The XrdCeph module
@@ -49,15 +48,10 @@ add_library(
 
 target_link_libraries(
   ${LIB_XRD_CEPH}
+  PRIVATE
   ${XROOTD_LIBRARIES}  
   XrdCephPosix )
 
-set_target_properties(
-  ${LIB_XRD_CEPH}
-  PROPERTIES
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
-
 #-------------------------------------------------------------------------------
 # The XrdCephXattr module
 #-------------------------------------------------------------------------------
@@ -70,15 +64,10 @@ add_library(
 
 target_link_libraries(
   ${LIB_XRD_CEPH_XATTR}
+  PRIVATE
   ${XROOTD_LIBRARIES}  
   XrdCephPosix )
 
-set_target_properties(
-  ${LIB_XRD_CEPH_XATTR}
-  PROPERTIES
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
-
 #-------------------------------------------------------------------------------
 # Install
 #-------------------------------------------------------------------------------

src/XrdCl/CMakeLists.txt

@@ -108,6 +108,7 @@ add_library(
 
 target_link_libraries(
   XrdCl
+  PRIVATE
   XrdXml
   XrdUtils
   uuid::uuid
@@ -125,7 +126,7 @@ set_target_properties(
 
 if( BUILD_XRDEC )
   target_include_directories(XrdCl PUBLIC ${ISAL_INCLUDE_DIRS})
-  target_link_libraries(XrdCl ${ISAL_LIBRARIES})
+  target_link_libraries(XrdCl PRIVATE ${ISAL_LIBRARIES})
 endif()
 
 #-------------------------------------------------------------------------------
@@ -157,6 +158,7 @@ add_executable(
 target_link_libraries(
   xrdcp
   XrdCl
+  XrdUtils
   XrdAppUtils )
 endif()
 

src/XrdClHttp/CMakeLists.txt

@@ -9,6 +9,6 @@ set(PLUGIN_NAME "XrdClHttp-${PLUGIN_VERSION}")
 
 add_library(${PLUGIN_NAME} MODULE ${libXrdClHttp_sources})
 
-target_link_libraries(${PLUGIN_NAME} Davix::Davix XrdCl XrdUtils)
+target_link_libraries(${PLUGIN_NAME} PRIVATE Davix::Davix XrdCl XrdUtils)
 
 install(TARGETS ${PLUGIN_NAME} LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR})

src/XrdCrypto.cmake

@@ -38,16 +38,15 @@ add_library(
 
 target_link_libraries(
   XrdCrypto
+  PRIVATE
   XrdUtils
   ${CMAKE_DL_LIBS} )
 
 set_target_properties(
   XrdCrypto
   PROPERTIES
   VERSION   ${XRD_CRYPTO_VERSION}
-  SOVERSION ${XRD_CRYPTO_SOVERSION}
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
+  SOVERSION ${XRD_CRYPTO_SOVERSION} )
 
 #-------------------------------------------------------------------------------
 # The XrdCryptoLite library
@@ -64,16 +63,15 @@ add_library(
 
 target_link_libraries(
   XrdCryptoLite
+  PRIVATE
   XrdUtils
   OpenSSL::Crypto )
 
 set_target_properties(
   XrdCryptoLite
   PROPERTIES
   VERSION   ${XRD_CRYPTO_LITE_VERSION}
-  SOVERSION ${XRD_CRYPTO_LITE_SOVERSION}
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
+  SOVERSION ${XRD_CRYPTO_LITE_SOVERSION} )
 
 #-------------------------------------------------------------------------------
 # The XrdCryptossl module
@@ -98,17 +96,12 @@ add_library(
 
 target_link_libraries(
   ${LIB_XRD_CRYPTOSSL}
+  PRIVATE
   XrdCrypto
   XrdUtils
   ${CMAKE_THREAD_LIBS_INIT}
   OpenSSL::SSL )
 
-set_target_properties(
-  ${LIB_XRD_CRYPTOSSL}
-  PROPERTIES
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
-
 #-------------------------------------------------------------------------------
 # Install
 #-------------------------------------------------------------------------------

src/XrdEc/CMakeLists.txt

@@ -20,10 +20,8 @@ add_library(
   XrdEcReader.hh               XrdEcReader.cc
 )
 
-target_link_libraries(
-  XrdEc
-  XrdCl
-)
+target_link_libraries(XrdEc PRIVATE XrdCl ${ISAL_LIBRARIES})
+target_include_directories(XrdEc PRIVATE ${ISAL_INCLUDE_DIRS})
 
 set_target_properties(
   XrdEc

src/XrdFfs.cmake

@@ -21,6 +21,7 @@ add_library(
 
 target_link_libraries(
   XrdFfs
+  PRIVATE
   XrdCl
   XrdPosix
   XrdUtils
@@ -30,9 +31,7 @@ set_target_properties(
   XrdFfs
   PROPERTIES
   VERSION   ${XRD_FFS_VERSION}
-  SOVERSION ${XRD_FFS_SOVERSION}
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
+  SOVERSION ${XRD_FFS_SOVERSION} )
 
 #-------------------------------------------------------------------------------
 # xrootdfs

src/XrdHttp.cmake

@@ -42,16 +42,19 @@ if( BUILD_HTTP )
 
   target_link_libraries(
     ${LIB_XRD_HTTP_UTILS}
+    PRIVATE
     XrdServer
     XrdUtils
     XrdCrypto
     ${CMAKE_DL_LIBS}
     ${CMAKE_THREAD_LIBS_INIT}
+    PUBLIC
     OpenSSL::SSL
     OpenSSL::Crypto )
 
   target_link_libraries(
     ${MOD_XRD_HTTP}
+    PRIVATE
     XrdUtils
     ${LIB_XRD_HTTP_UTILS} )
 

src/XrdMacaroons.cmake

@@ -20,15 +20,17 @@ if( BUILD_MACAROONS )
     XrdMacaroons/XrdMacaroonsConfigure.cc)
 
   target_link_libraries(
-    ${LIB_XRD_MACAROONS} ${CMAKE_DL_LIBS}
+    ${LIB_XRD_MACAROONS}
+    PRIVATE
     XrdHttpUtils
     XrdUtils
     XrdServer
     uuid::uuid
     ${MACAROONS_LIB}
     ${JSON_LIBRARIES}
     ${XROOTD_HTTP_LIB}
-    OpenSSL::Crypto)
+    OpenSSL::Crypto
+    ${CMAKE_DL_LIBS})
 
   if( MacOSX )
     SET( MACAROONS_LINK_FLAGS "-Wl")
@@ -39,8 +41,6 @@ if( BUILD_MACAROONS )
   set_target_properties(
     ${LIB_XRD_MACAROONS}
     PROPERTIES
-    INTERFACE_LINK_LIBRARIES ""
-    LINK_INTERFACE_LIBRARIES ""
     LINK_FLAGS "${MACAROONS_LINK_FLAGS}")
 
   #-----------------------------------------------------------------------------

src/XrdOssCsi.cmake

@@ -29,16 +29,11 @@ add_library(
 
 target_link_libraries(
   ${LIB_XRD_OSSCSI}
+  PRIVATE
   XrdUtils
   XrdServer
   ${CMAKE_THREAD_LIBS_INIT} )
 
-set_target_properties(
-  ${LIB_XRD_OSSCSI}
-  PROPERTIES
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
-
 #-------------------------------------------------------------------------------
 # Install
 #-------------------------------------------------------------------------------

src/XrdPfc.cmake

@@ -32,18 +32,13 @@ add_library(
 
 target_link_libraries(
   ${LIB_XRD_FILECACHE}
+  PRIVATE
 # XrdPosix
   XrdCl
   XrdUtils
   XrdServer
   ${CMAKE_THREAD_LIBS_INIT} )
 
-set_target_properties(
-  ${LIB_XRD_FILECACHE}
-  PROPERTIES
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
-
 #-------------------------------------------------------------------------------
 # The XrdBlacklistDecision library
 #-------------------------------------------------------------------------------
@@ -54,15 +49,10 @@ add_library(
 
 target_link_libraries(
   ${LIB_XRD_BLACKLIST}
+  PRIVATE
   XrdUtils
   )
 
-set_target_properties(
-  ${LIB_XRD_BLACKLIST}
-  PROPERTIES
-  INTERFACE_LINK_LIBRARIES ""
-  LINK_INTERFACE_LIBRARIES "" )
-
 #-------------------------------------------------------------------------------
 # xrdpfc_print
 #-------------------------------------------------------------------------------