Skip to content

Commit

Permalink
Revert "Merge pull request #679 from bbockelm/xrootd-tpc-rename"
Browse files Browse the repository at this point in the history
This reverts commit e3550ce, reversing
changes made to a768fd6.

It has been decided that this PR is to be reverted as it does not follow
XRootD coding conventions and brakes the build on vanilla RHEL6 platform
in presence of libcurl-devel package. There should be a check in the
CMake infrastructures that ensures the XrdTpc package will be only built
if a proper version of libcurl-devel is present (or XrdTpc should built
with version of libcurl-devel provided in raw RHEL6 environment).
Moreover the new component should be packaged properly (if neccessary
a _with_tpchttp macro should be tested in the spec file).
  • Loading branch information
simonmichal committed May 8, 2018
1 parent 8c671ad commit d46c516
Show file tree
Hide file tree
Showing 16 changed files with 1 addition and 1,980 deletions.
9 changes: 0 additions & 9 deletions cmake/XRootDFindLibs.cmake
Expand Up @@ -27,9 +27,6 @@ if( SYSTEMD_FOUND )
add_definitions( -DHAVE_SYSTEMD )
endif()

include (FindPkgConfig)
pkg_check_modules(CURL libcurl)

if( ENABLE_CRYPTO )
find_package( OpenSSL )
if( OPENSSL_FOUND )
Expand Down Expand Up @@ -73,14 +70,8 @@ endif()
if( ENABLE_HTTP )
if( OPENSSL_FOUND AND BUILD_CRYPTO )
set( BUILD_HTTP TRUE )
if( CURL_FOUND )
set( BUILD_TPC TRUE )
else()
set( BUILD_TPC FALSE )
endif()
else()
set( BUILD_HTTP FALSE )
set( BUILD_TPC FALSE )
endif()
endif()

Expand Down
1 change: 0 additions & 1 deletion src/CMakeLists.txt
Expand Up @@ -38,7 +38,6 @@ include( XrdFileCache )

if( BUILD_HTTP )
include( XrdHttp )
include( XrdTpc )
endif()

if( BUILD_CEPH )
Expand Down
5 changes: 1 addition & 4 deletions src/XrdHttp.cmake
Expand Up @@ -15,11 +15,9 @@ if( BUILD_HTTP )
#-----------------------------------------------------------------------------
include_directories( ${OPENSSL_INCLUDE_DIR} )

# Note this is marked as a shared library as XrdHttp plugins are expected to
# link against this for the XrdHttpExt class implementations.
add_library(
${LIB_XRD_HTTP}
SHARED
MODULE
XrdHttp/XrdHttpProtocol.cc XrdHttp/XrdHttpProtocol.hh
XrdHttp/XrdHttpReq.cc XrdHttp/XrdHttpReq.hh
XrdHttp/XrdHttpSecXtractor.hh
Expand All @@ -42,7 +40,6 @@ if( BUILD_HTTP )
${LIB_XRD_HTTP}
PROPERTIES
INTERFACE_LINK_LIBRARIES ""
SUFFIX ".so"
LINK_INTERFACE_LIBRARIES "" )

#-----------------------------------------------------------------------------
Expand Down
51 changes: 0 additions & 51 deletions src/XrdTpc.cmake

This file was deleted.

59 changes: 0 additions & 59 deletions src/XrdTpc/CMakeLists.txt

This file was deleted.

121 changes: 0 additions & 121 deletions src/XrdTpc/README.md

This file was deleted.

0 comments on commit d46c516

Please sign in to comment.