[XrdEc] Make sure the global status is checked before closing the dat…

…a object.
xrootd · Jan 20, 2021 · fbc9b4f · fbc9b4f
1 parent 1537c5d
commit fbc9b4f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/XrdEc/XrdEcReader.cc b/src/XrdEc/XrdEcReader.cc
@@ -42,7 +42,6 @@
 #include <iterator>
 #include <numeric>
 #include <tuple>
-#include <iostream>
 
 namespace XrdEc
 {

diff --git a/src/XrdEc/XrdEcStrmWriter.cc b/src/XrdEc/XrdEcStrmWriter.cc
@@ -172,7 +172,6 @@ namespace XrdEc
                                //----------------------------------------------
                                // Select another server
                                //----------------------------------------------
-                               size_t srvid;
                                if( !servers->dequeue( srvid ) ) return; // if there are no more servers we simply fail
                                zip = *dataarchs[srvid];
                                //----------------------------------------------
@@ -253,6 +252,13 @@ namespace XrdEc
   //---------------------------------------------------------------------------
   void StrmWriter::CloseImpl( XrdCl::ResponseHandler *handler )
   {
+    //-------------------------------------------------------------------------
+    // First, check the global status, if we are in an error state just
+    // fail the request.
+    //-------------------------------------------------------------------------
+    XrdCl::XRootDStatus gst = global_status.get();
+    if( !gst.IsOK() ) return ScheduleHandler( handler, gst );
+
     const size_t size = objcfg.plgr.size();
     //-------------------------------------------------------------------------
     // prepare the metadata (the Central Directory of each data ZIP)