hostname can be longer than 64 chars

[faluchet]

xrootd/src/XrdSys/XrdSysDNS.cc

Line 255 in a9d5483

{char dnbuff[64];

When deploying EOS on Kubernetes, I had some spare chances to get a truncated hostname when this was longer than 64 chars, resulting in misconfigurations/erroneous setup. Is this limit still necessary?

Perhaps https://github.com/xrootd/xrootd/blob/master/src/XrdSys/XrdSysDNS.hh#L182
is involved too.

• faluchet@cern.ch

[xrootd-dev]

Hello, Two things here: 1) XrdSysDNS is deprecated and should not be used because it only supports IPv4. The replacement is XrdNetAddr which is derived from XrdNetInfo. 2) There is no restriction to 64 characters and the what is being referenced here is a misleading comment. The comment suggests that 64 characters is long enough but that is untrue, obviously. I don't think EOS uses XrdSysDNS anymore and if it does it likely specifies a buffer at least 256 bytes long. Andy

…

On Mon, 7 Oct 2019, falu0 wrote: https://github.com/xrootd/xrootd/blob/a9d548302045259c17f11709580f316a698fe697/src/XrdSys/XrdSysDNS.cc#L255 When deploying [EOS](http://eos.web.cern.ch/) on Kubernetes, I had some spare chances to get a truncated hostname when this was longer than 64 chars, resulting in misconfigurations/erroneous setup. Is this limit still necessary? Perhaps https://github.com/xrootd/xrootd/blob/master/src/XrdSys/XrdSysDNS.hh#L182 is involved too. - ***@***.*** -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #1064 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1