[HTTP] XrdCmsClient::Locate isn't handed a correct XrdOucEnv *EnvInfo in case of HTTP

[panik4]

Hi,

to give some context, I am currently adding redirect to local filesystem functionality to XRootd-HTTP.

The current plug-in for redirectToLocal XrdCmsRedirLocal is working for the root-protocol, but not for http.

This is due to the fact that EnvInfo->secEnv()->addrInfo; is accessed in the Locate method, to make the necessary checks to see, if a redirect to local is allowed. Source

However, when using HTTP to access the redirector, the addrInfo is null.

Is this by design? Was it simply not required?
Is there a possibility to get the addrInfo added for HTTP?

Cheers,
Paul

[abh3]

No, this is clearly an oversight. I think I fixed that in R5 but I will look again.

…

On Wed, 1 Jul 2020, pkramp wrote: Hi, to give some context, I am currently adding redirect to local filesystem functionality to XRootd-HTTP. The current plug-in for redirectToLocal **XrdCmsRedirLocal** is working for the root-protocol, but not for http. This is due to the fact that **EnvInfo->secEnv()->addrInfo;** is accessed in the Locate method, to make the necessary checks to see, if a redirect to local is allowed. Source: [https://github.com/xrootd/xrootd/blob/master/src/XrdCms/XrdCmsRedirLocal.cc#L111] However, when using HTTP to access the redirector, the addrInfo is null. Is this by design? Was it simply not required? Is there a possibility to get the addrInfo added for HTTP? Cheers, Paul -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #1233

[abh3]

Indeed, this is fixed in R5. A back port is relatively messy. OK, if you get that starting in R5?

[panik4]

I think we will be fine with R5.
I will get back to you soon with a pull-request.

So far, the changes seem to be minor.

Thanks,
Paul

[panik4]

I have created the pull-request, closing this as the underlying bug was fixed for R5