XRDTPC_TPROT is set to the value of XRDTPC_SPROT

[murrayc3]

The following code fragment shows that the value of XRDTPC_TPROT is set to the value of XRDTPC_SPROT. Line 305 incorrectly does eVec[i++] = sprBuff; when it should do eVec[i++] = tprBuff;.

[localhost] ~ > vi xrootd/src/XrdOfs/XrdOfsTPCProg.cc
...
292 // Export source protocol if present
293 //
294    char sprBuff[128];
295    if (Job->Info.Spr)
296       {snprintf(sprBuff, sizeof(sprBuff), "XRDTPC_SPROT=%s", Job->Info.Spr);
297        eVec[i++] = sprBuff;
298       }
299 
300 // Export target protocol if present
301 //
302    char tprBuff[128];
303    if (Job->Info.Tpr)
304       {snprintf(tprBuff, sizeof(tprBuff), "XRDTPC_TPROT=%s", Job->Info.Tpr);
305        eVec[i++] = sprBuff;
306       }

[xrootd-dev]

Could make a pull request to fix this so that you can be the person of record who spotted an fixed the problem.

…

On Thu, 26 Nov 2020, murrayc3 wrote: The following code fragment shows that the value of `XRDTPC_TPROT` is set to the value of `XRDTPC_SPROT`. Line `305` incorrectly does `eVec[i++] = sprBuff;` when it should do `eVec[i++] = tprBuff;`. ``` [localhost] ~ > vi xrootd/src/XrdOfs/XrdOfsTPCProg.cc ... 292 // Export source protocol if present 293 // 294 char sprBuff[128]; 295 if (Job->Info.Spr) 296 {snprintf(sprBuff, sizeof(sprBuff), "XRDTPC_SPROT=%s", Job->Info.Spr); 297 eVec[i++] = sprBuff; 298 } 299 300 // Export target protocol if present 301 // 302 char tprBuff[128]; 303 if (Job->Info.Tpr) 304 {snprintf(tprBuff, sizeof(tprBuff), "XRDTPC_TPROT=%s", Job->Info.Tpr); 305 eVec[i++] = sprBuff; 306 } ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #1338 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1

[abh3]

This was fixed by a supplied pull request.