"triedrc" is missing when XrdCl get no errNo

[wyang007]

In some cases XrdCl will not get an errNo. For example, when the connection and retry timeout. In that case, XRootDMsgHandler::UpdateTriedCGI() set "tried=" but does not set "triedrc=". Do we want to set "triedrc" to something?

[xrootd-dev]

Yes, we want triedrc=srverr as that's the closest approximation of the problem.

…

On Fri, 26 Mar 2021, Wei Yang wrote: In some cases XrdCl will not get an errNo. For example, when the connection and retry timeout. In that case, XRootDMsgHandler::UpdateTriedCGI() set "tried=" but does not set "triedrc=". Do we want to set "triedrc" to something? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #1435 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1

[simonmichal]

Wouldn't it make more sense to introduce 2 new codes say connerr for timeouts and redirlim for redirect limit?

[osschar]

What happens in such a case when triedrc=resel is already set? Does the additional code (srverr or one of the new ones) get appended, like triedrc=resel,srverr?

[simonmichal]

well, I suppose it's for us to decide ;-) currently from what I see triedrc has just one value.

[abh3]

The triedrc is a rather blunt approximation of what is wrong. The server uses it to determine how the selection of a new node should proceed. It doesn't much matter what the error is for server related errors, so keeping it as srverr is just fine. For ioerrs, the redirector may decide to blacklist the server for that file for a while, for enoent the redirector will refresh the cache before selecting a new node. The resel rc limits the selection process. So, I don't think it's necessary to introduce any more error codes as the ones we have are good enough. The triedrc only has to indicate the last immediate error, the redirector does not need nor use any history/ So, additional codes are never appended to the triedrc.

[simonmichal]

@abh3 : thanks for the clarification, so srverr it is!

[simonmichal]

That's about it: e9fb99b

I'll close this one, if there are any problems with the solution please reopen.